user provided contributions flows all the way to the generated code #41
Conversation
dp_creator_ii/tests/test_template.py
Outdated
There was a problem hiding this comment.
The changes in this file for the PR look good, but I wanted to ask about test_fill_values() - can there be more assertions here, for the other lines in the context_block? Also in test_make_script(), the test is checking that the python script runs without error, but it doesn't check the contents of the script. Even though you are testing the other functions individually, it could be good to test that the final script has the correct contents.
There was a problem hiding this comment.
For test_fill_values, I was thinking of it as a unit test of the template filling, so I think the best resolution is to make it simpler, so it only does that.
I will make test_make_script stronger, since it is more of an integration test. Thanks!
|
Oh: applying black to the script fixture made it diverge from what we actually output. fixing... |
|
There is still work to do in this area, so I've filed a couple follow-up issues, but I think this much makes sense for now. |
contributions, a number, fromprivacy_unit, an particular OpenDP object.ui_helpers.pyfor UI code that should be reused. (For now, putting the code sample under a<details>tag is easy, but if we want to change it in the future, we should do it in one place.)